Skip to content

ThirdwebBridge - Onramp Integration & Improved APIs #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented May 9, 2025

Closes TOOL-4441


PR-Codex overview

This PR focuses on enhancing the ThirdwebBridge functionality by updating transaction handling to use Steps instead of Transactions, introducing new methods for onramp operations, and improving data structures for transaction steps and quotes.

Detailed summary

  • Updated Execute methods to use Steps instead of Transactions.
  • Added OnrampPrepareData and OnrampStatusData classes for onramp operations.
  • Introduced new methods: Onramp_Prepare and Onramp_Status.
  • Refactored Transaction and QuoteData classes to accommodate new structures.
  • Deprecated the use of Transactions in favor of Steps in various data classes.
  • Enhanced error handling and API request structure in Buy and Sell methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented May 9, 2025

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 183 lines in your changes missing coverage. Please review.

Project coverage is 61.00%. Comparing base (ea4d093) to head (151f474).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
Thirdweb/Thirdweb.Bridge/ThirdwebBridge.cs 0.00% 96 Missing ⚠️
Thirdweb/Thirdweb.Bridge/ThirdwebBridge.Types.cs 0.00% 66 Missing ⚠️
...rdweb/Thirdweb.Bridge/ThirdwebBridge.Extensions.cs 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   62.19%   61.00%   -1.19%     
==========================================
  Files          41       41              
  Lines        6427     6563     +136     
  Branches      822      832      +10     
==========================================
+ Hits         3997     4004       +7     
- Misses       2243     2373     +130     
+ Partials      187      186       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xFirekeeper 0xFirekeeper merged commit 2a268cd into main May 9, 2025
3 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/onramp-bridge-v2 branch May 9, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants