Skip to content

limit concurrent rpc requests in worker #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

limit concurrent rpc requests in worker #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions internal/worker/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,17 @@ func NewWorker(rpc rpc.IRPCClient) *Worker {
}
}

func (w *Worker) processChunkWithRetry(ctx context.Context, chunk []*big.Int, resultsCh chan<- []rpc.GetFullBlockResult) {
func (w *Worker) processChunkWithRetry(ctx context.Context, chunk []*big.Int, resultsCh chan<- []rpc.GetFullBlockResult, sem chan struct{}) {
select {
case <-ctx.Done():
return
default:
}

defer func() {
time.Sleep(time.Duration(config.Cfg.RPC.Blocks.BatchDelay) * time.Millisecond)
}()

// Try with current chunk size
// Acquire semaphore only for the RPC request
sem <- struct{}{}
results := w.rpc.GetFullBlocks(ctx, chunk)
<-sem // Release semaphore immediately after RPC request

if len(chunk) == 1 {
// chunk size 1 is the minimum, so we return whatever we get
Expand All @@ -56,6 +54,7 @@ func (w *Worker) processChunkWithRetry(ctx context.Context, chunk []*big.Int, re
}
}

log.Debug().Msgf("Out of %d blocks, %d successful, %d failed", len(results), len(successfulResults), len(failedBlocks))
// If we have successful results, send them
if len(successfulResults) > 0 {
resultsCh <- successfulResults
Expand All @@ -68,7 +67,7 @@ func (w *Worker) processChunkWithRetry(ctx context.Context, chunk []*big.Int, re

// can't split any further, so try one last time
if len(failedBlocks) == 1 {
w.processChunkWithRetry(ctx, failedBlocks, resultsCh)
w.processChunkWithRetry(ctx, failedBlocks, resultsCh, sem)
return
}

Expand All @@ -84,12 +83,12 @@ func (w *Worker) processChunkWithRetry(ctx context.Context, chunk []*big.Int, re

go func() {
defer wg.Done()
w.processChunkWithRetry(ctx, leftChunk, resultsCh)
w.processChunkWithRetry(ctx, leftChunk, resultsCh, sem)
}()

go func() {
defer wg.Done()
w.processChunkWithRetry(ctx, rightChunk, resultsCh)
w.processChunkWithRetry(ctx, rightChunk, resultsCh, sem)
}()

wg.Wait()
Expand All @@ -102,9 +101,15 @@ func (w *Worker) Run(ctx context.Context, blockNumbers []*big.Int) []rpc.GetFull
var wg sync.WaitGroup
resultsCh := make(chan []rpc.GetFullBlockResult, blockCount)

// Create a semaphore channel to limit concurrent goroutines
sem := make(chan struct{}, 20)

log.Debug().Msgf("Worker Processing %d blocks in %d chunks of max %d blocks", blockCount, len(chunks), w.rpc.GetBlocksPerRequest().Blocks)

for _, chunk := range chunks {
for i, chunk := range chunks {
if i > 0 {
time.Sleep(time.Duration(config.Cfg.RPC.Blocks.BatchDelay) * time.Millisecond)
}
select {
case <-ctx.Done():
log.Debug().Msg("Context canceled, stopping Worker")
Expand All @@ -116,7 +121,7 @@ func (w *Worker) Run(ctx context.Context, blockNumbers []*big.Int) []rpc.GetFull
wg.Add(1)
go func(chunk []*big.Int) {
defer wg.Done()
w.processChunkWithRetry(ctx, chunk, resultsCh)
w.processChunkWithRetry(ctx, chunk, resultsCh, sem)
}(chunk)
}

Expand Down