catch panic from decodeLogFunc #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA panic recovery mechanism was introduced in the goroutine responsible for log decoding within the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant DecodeLogs
participant Goroutine
participant Logger
Caller->>DecodeLogs: Call DecodeLogs(logs, chainId)
loop For each log
DecodeLogs->>Goroutine: Launch decodeLogFunc in goroutine
alt Panic occurs in Goroutine
Goroutine->>Logger: Log error with chainId, logs, and panic error
else No panic
Goroutine->>Goroutine: Process log normally
end
end
DecodeLogs-->>Caller: Return results
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
internal/common/log.go (1)
88-131: Consider adding bounds checking for concurrent slice access.While the current implementation uses proper synchronization with WaitGroup, there's a potential race condition concern. The
decodedLogsslice is accessed concurrently by multiple goroutines without explicit bounds checking.Consider adding bounds validation to make the code more robust:
go func(idx int, eventLog Log, mut *sync.Mutex) { + if idx >= len(decodedLogs) { + log.Error().Int("index", idx).Int("length", len(decodedLogs)).Msg("Index out of bounds in DecodeLogs") + wg.Done() + return + } defer func() { if err := recover(); err != nil { log.Error().This prevents potential out-of-bounds access in edge cases where the slice might be modified concurrently.
iuwqyir
reviewed
Jun 3, 2025
iuwqyir
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit