fixed indexed log params decoding

[iuwqyir]

TL;DR

Improved handling of indexed event parameters in Ethereum logs.

Dynamic size types will be keccak256 hashes into the topic value, so we cannot decode them

What changed?

• Consolidated the handling of StringTy, BytesTy, and FixedBytesTy types to return hex-encoded strings
• Replaced specific error handling for unsupported types (SliceTy, ArrayTy, TupleTy) with a default case that returns the raw topic string
• Simplified the error handling logic for indexed parameters

How to test?

1. Test decoding logs with indexed string parameters
2. Verify that previously unsupported types now return the raw topic value instead of an error
3. Ensure that hex encoding for byte types and strings works correctly

Why make this change?

This change improves the robustness of log decoding by:

1. Providing consistent handling for string and byte types
2. Allowing the application to continue processing even with complex indexed types instead of failing
3. Simplifying the code while maintaining functionality for common types

Summary by CodeRabbit

• Bug Fixes
  • Improved consistency in how string and byte types are decoded from indexed log topics, now returning them as hex-encoded strings prefixed with "0x".
  • Enhanced error handling for unsupported or unknown indexed argument types by returning the raw topic string instead of an error.

[coderabbitai]

Walkthrough

The decoding logic for indexed log topics in decodeIndexedArgument was updated. Now, string, bytes, and fixed bytes types are all decoded as hex-encoded strings prefixed with "0x". Error handling for unsupported types was removed, and any unhandled types now return the raw topic string without error.

Changes

File(s)	Change Summary
internal/common/log.go	Modified decodeIndexedArgument to unify decoding of string/bytes types as hex, and relaxed error handling for unsupported types.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant decodeIndexedArgument

    Caller->>decodeIndexedArgument: Provide (type, topic string)
    alt type is String, Bytes, or FixedBytes
        decodeIndexedArgument->>Caller: Return hex-encoded string with "0x" prefix
    else type is unhandled (e.g., Slice, Array, Tuple)
        decodeIndexedArgument->>Caller: Return raw topic string
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03325a3 and a0381ed.

📒 Files selected for processing (1)

• internal/common/log.go (2 hunks)

🔇 Additional comments (2)

internal/common/log.go (2)

191-192: Excellent fix for indexed string parameter handling.

Consolidating StringTy with BytesTy and FixedBytesTy to return hex-encoded strings is the correct approach. Indexed string parameters are stored as keccak256 hashes in Ethereum logs and cannot be decoded back to their original string values, so returning the hex representation is both accurate and consistent.

---

203-203: Improved error handling for unsupported indexed types.

Returning the raw topic string instead of an error for unsupported types is a robust approach that prevents processing failures while still providing useful information. This allows the application to handle complex indexed types gracefully without halting the entire decoding process.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[iuwqyir]

• fixed indexed log params decoding #222 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.