add possibility to poll without saving

[iuwqyir]

TL;DR

Refactored the Poller to separate block polling from data storage operations.

What changed?

• Split the Poll method into two separate methods:
  • PollWithoutSaving: Handles only the polling of blocks without storing data
  • StageResults: Handles the storage of polled block data
• Moved the worker results handling logic into these new methods
• Added functionality to track and return the highest block number polled
• Created a helper method convertPollResultsToBlockData to transform poll results into block data

How to test?

1. Run the existing test suite to ensure all functionality works as expected
2. Test the new PollWithoutSaving method by calling it directly and verifying it returns the correct block data without saving
3. Test the StageResults method by passing block data and verifying it's properly stored
4. Verify that the Poll method still returns the highest block number correctly

Why make this change?

This refactoring improves the separation of concerns in the Poller, making it more flexible by allowing clients to poll blocks without immediately saving the data. This enables more advanced use cases where data processing might be needed before storage, and makes the code more maintainable by breaking down the monolithic polling function into smaller, more focused components.

Summary by CodeRabbit

• Refactor
  • Enhanced the polling process to improve data handling and error reporting, resulting in more reliable background operations without affecting user-facing features.

[coderabbitai]

Walkthrough

The Poll method in the orchestrator's poller was refactored to separate block polling from data staging. New methods were introduced to handle polling without saving, converting poll results, and staging results. The previous monolithic result handling method was removed, and logic was modularized for clearer separation of responsibilities.

Changes

File	Change Summary
internal/orchestrator/poller.go	Refactored Poll to delegate polling and staging; added PollWithoutSaving, convertPollResultsToBlockData, and StageResults methods; removed handleWorkerResults.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Poller
    participant Worker
    participant Storage

    Caller->>Poller: Poll(ctx, blockNumbers)
    Poller->>Poller: PollWithoutSaving(ctx, blockNumbers)
    Poller->>Worker: Fetch blocks
    Worker-->>Poller: Block fetch results
    Poller->>Poller: convertPollResultsToBlockData(results)
    Poller->>Poller: StageResults(successfulBlocks, failedResults)
    Poller->>Storage: Insert successful block data
    Poller->>Poller: handleBlockFailures(failedResults)
    Poller-->>Caller: Return latest polled block

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca1698e and 4139a04.

📒 Files selected for processing (1)

• internal/orchestrator/poller.go (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• internal/orchestrator/poller.go

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[iuwqyir]

• publish metrics only when actually publishing #227
• poll new blocks in the committer when in live mode #226
• add possibility to poll without saving #225 👈 (View in Graphite)
• setup workmode determination and update #224
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84624f5 and ca1698e.

📒 Files selected for processing (1)

• internal/orchestrator/poller.go (2 hunks)

🔇 Additional comments (1)

internal/orchestrator/poller.go (1)

190-193: Update lastPolledBlock only after successful fetch

p.lastPolledBlock is advanced before the worker runs.
If every RPC call in the batch fails, the poller will still skip these blocks forever.
Consider moving the assignment after convertPollResultsToBlockData and only when
len(blockData) > 0.