Skip to content

publish metrics only when actually publishing #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

publish metrics only when actually publishing #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions internal/orchestrator/committer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,13 +253,10 @@ func (c *Committer) commit(ctx context.Context, blockData []common.BlockData) er
log.Debug().Str("metric", "main_storage_insert_duration").Msgf("MainStorage.InsertBlockData duration: %f", time.Since(mainStorageStart).Seconds())
metrics.MainStorageInsertDuration.Observe(time.Since(mainStorageStart).Seconds())

publishStart := time.Now()
go func() {
if err := c.publisher.PublishBlockData(blockData); err != nil {
log.Error().Err(err).Msg("Failed to publish block data to kafka")
}
log.Debug().Str("metric", "publish_duration").Msgf("Publisher.PublishBlockData duration: %f", time.Since(publishStart).Seconds())
metrics.PublishDuration.Observe(time.Since(publishStart).Seconds())
}()

stagingDeleteStart := time.Now()
Expand Down
19 changes: 10 additions & 9 deletions internal/publisher/publisher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,7 @@ func (p *Publisher) initialize() error {
}

func (p *Publisher) PublishBlockData(blockData []common.BlockData) error {
err := p.publishBlockData(blockData, false)
if err != nil {
return err
}
metrics.PublisherBlockCounter.Add(float64(len(blockData)))
metrics.LastPublishedBlock.Set(float64(blockData[len(blockData)-1].Block.Number.Int64()))
return nil
return p.publishBlockData(blockData, false)
}

func (p *Publisher) PublishReorg(oldData []common.BlockData, newData []common.BlockData) error {
Expand All @@ -114,8 +108,6 @@ func (p *Publisher) PublishReorg(oldData []common.BlockData, newData []common.Bl
if err := p.publishBlockData(newData, false); err != nil {
return fmt.Errorf("failed to publish new block data: %v", err)
}

metrics.PublisherReorgedBlockCounter.Add(float64(len(oldData)))
return nil
}

Expand Down Expand Up @@ -168,6 +160,8 @@ func (p *Publisher) publishBlockData(blockData []common.BlockData, isReorg bool)
return nil
}

publishStart := time.Now()

// Prepare messages for blocks, events, transactions and traces
blockMessages := make([]*kgo.Record, len(blockData))
var eventMessages []*kgo.Record
Expand Down Expand Up @@ -251,6 +245,13 @@ func (p *Publisher) publishBlockData(blockData []common.BlockData, isReorg bool)
}
}

log.Debug().Str("metric", "publish_duration").Msgf("Publisher.PublishBlockData duration: %f", time.Since(publishStart).Seconds())
metrics.PublishDuration.Observe(time.Since(publishStart).Seconds())
metrics.PublisherBlockCounter.Add(float64(len(blockData)))
metrics.LastPublishedBlock.Set(float64(blockData[len(blockData)-1].Block.Number.Int64()))
if isReorg {
metrics.PublisherReorgedBlockCounter.Add(float64(len(blockData)))
}
return nil
}

Expand Down