handle reset chains

[iuwqyir]

TL;DR

Added a check to prevent processing when the RPC has fewer blocks than have been committed.

What changed?

Added a validation check in the getBlockNumbersToCommit function that returns an error when the calculated block count is less than 1, which indicates that more blocks have been committed than are available in the RPC node - potentially signaling a chain reset.

How to test?

1. Set up a scenario where the RPC node has fewer blocks than what has been committed
2. Verify that the function returns an empty block array and the appropriate error message
3. Ensure the orchestrator handles this error gracefully

Why make this change?

This change prevents the system from attempting to process an invalid range of blocks when a chain reset may have occurred. Without this check, the system might try to process a negative number of blocks, leading to unexpected behavior or crashes. This improves resilience against chain reorganizations or RPC node inconsistencies.

Summary by CodeRabbit

• Bug Fixes
  • Improved validation to prevent committing an invalid or negative block range, reducing errors when the available blocks are fewer than expected.

[coderabbitai]

Walkthrough

A validation check was introduced in the getBlockNumbersToCommit method within the Committer struct. The function now returns an error and an empty result if the computed block count is less than one, handling cases where more blocks have been committed than are available, which may indicate a chain reset.

Changes

File	Change Summary
internal/orchestrator/committer.go	Added a validation to getBlockNumbersToCommit to return early with an error if block count < 1

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Committer

    Caller->>Committer: getBlockNumbersToCommit()
    Committer->>Committer: Calculate blockCount
    alt blockCount < 1
        Committer-->>Caller: Return error and empty slice
    else blockCount >= 1
        Committer-->>Caller: Return block numbers to commit
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a72a39 and 05d334a.

📒 Files selected for processing (1)

• internal/orchestrator/committer.go (1 hunks)

🔇 Additional comments (1)

internal/orchestrator/committer.go (1)

138-140: Excellent defensive programming for chain reset scenarios.

This validation check effectively handles the edge case where the RPC node has fewer blocks than already committed, which can occur during chain resets or reorganizations. The implementation correctly:

• Prevents processing invalid/negative block ranges
• Returns an appropriate error message explaining the likely cause
• Allows the system to gracefully handle this condition through existing error handling patterns

The change enhances the system's resilience and prevents potential crashes from unexpected blockchain state inconsistencies.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[iuwqyir]

• handle reset chains #229 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.