-
Notifications
You must be signed in to change notification settings - Fork 19
fix race condition in tests #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fa6ef80
to
f0325ba
Compare
4806fc3
to
28a1338
Compare
TL;DR
Improved transaction search test with time-based filtering and updated mock expectations.
What changed?
TestSearch_TransactionHash
to properly test time-based transaction searches:.On()
to.EXPECT()
in address and function signature tests for consistencyHow to test?
Run the test suite to verify that the transaction search functionality works correctly with the time-based filtering:
Why make this change?
The previous test implementation didn't properly validate time-based transaction searches, which are important for performance optimization. This change ensures that the search handler correctly queries transactions in different time ranges (recent, medium-term, and older transactions) before returning results, providing better test coverage for the actual search behavior.