Skip to content

configuartion of syncCtx check #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged

configuartion of syncCtx check #216

merged 1 commit into from
Sep 27, 2024

Conversation

BoysheO
Copy link
Contributor

@BoysheO BoysheO commented Sep 27, 2024

fix #215


PR-Codex overview

This PR introduces a conditional check for the synchronization context in the WalletConnect.cs file, allowing for flexibility in the synchronization context validation based on a configuration switch.

Detailed summary

  • Added a boolean isSkipSyncCtxCheck to determine if the synchronization context check should be skipped.
  • Updated the if statement to include the isSkipSyncCtxCheck condition.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper
Copy link
Member

lgtm, ty!

@0xFirekeeper 0xFirekeeper merged commit 10247ab into thirdweb-dev:v5 Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use SynchronizationContext.Current to detect whether sdk are in the main thread.
2 participants