Skip to content

Enables custom implementation for OTP Verification Modal #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Vingator
Copy link
Contributor

@Vingator Vingator commented Oct 31, 2024

Allows custom implementation for the OTP Verification Modal by implementing AbstractOTPVerifyModal.


PR-Codex overview

This PR focuses on refactoring the OTP verification modal system in the Thirdweb Unity project. It introduces a new abstract class for OTP verification and modifies existing wallet modals to inherit from it, improving code organization and reusability.

Detailed summary

  • Deleted EcosystemWalletModal and InAppWalletModal prefab files.
  • Created AbstractOTPVerifyModal class for common OTP functionality.
  • Implemented DefaultOTPVerifyModal inheriting from AbstractOTPVerifyModal.
  • Updated prefab names and references from EcosystemWalletModal to DefaultOTPModal.
  • Refactored OTP login logic to use the new abstract class.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper
Copy link
Member

Thanks for the PR, will take a look and make sure it's in by next release! Probably good for Ecosystem Wallets as well.

@0xFirekeeper 0xFirekeeper merged commit 19698d4 into thirdweb-dev:v5 Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants