Compaction by tombstone ratio in simpledb #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new compaction kind that will compact sstables when they have more than 20% of their keys tombstoned. This should save space when preserving them, as a later compaction can clean them up again. This trades-off available disk bandwidth and CPU with disk space.
|
Nice. I will be in holliday next week. So maybe not connected so much. Thanks |
|
enjoy and thank you for your time
…On Fri, 14 Feb 2025, 18:01 Sébastien HEITZMANN, ***@***.***> wrote:
Nice. I will be in holliday next week. So maybe not connected so much.
Thanks
—
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGVYMDUYZ4VVYT4KUGBNET2PYOPLAVCNFSM6AAAAABXE6MGKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHAZTSMBTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: sebheitzmann]*sebheitzmann* left a comment
(thomasjungblut/go-sstables#46)
<#46 (comment)>
Nice. I will be in holliday next week. So maybe not connected so much.
Thanks
—
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGVYMDUYZ4VVYT4KUGBNET2PYOPLAVCNFSM6AAAAABXE6MGKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHAZTSMBTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
thomasjungblut
added a commit
that referenced
this pull request
Feb 28, 2025
This commit introduces a new compaction kind that will compact sstables when they have more than 20% of their keys tombstoned. This should save space when preserving them, as a later compaction can clean them up again. This trades-off available disk bandwidth and CPU with disk space. Co-authored-by: Thomas Jungblut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new compaction kind that will compact sstables when they have more than 20% of their keys tombstoned. This should save space when preserving them, as a later compaction can clean them up again. This trades-off available disk bandwidth and CPU with disk space.
cc @sebheitzmann I think I have to add a few more tests, but it seems to certainly fix the regression test from the previous PR.