Pick Add blocking callback to EnvBuilder (#474) #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xintao <[email protected]>
hicqu
previously approved these changes
Jul 15, 2020
BusyJay
previously approved these changes
Jul 15, 2020
Signed-off-by: Xintao <[email protected]>
hunterlxt
force-pushed
the
xt/pick-474
branch
3 times, most recently
from
9a98209 to
95c8fe1
Compare
|
Windows build error is not related to this PR |
|
Better fix it before releasing a new version. |
BusyJay
reviewed
Jul 17, 2020
Signed-off-by: Xintao <[email protected]>
hunterlxt
force-pushed
the
xt/pick-474
branch
4 times, most recently
from
f64f54a to
ac88ed4
Compare
Signed-off-by: Xintao <[email protected]>
BusyJay
reviewed
Jul 20, 2020
Signed-off-by: Xintao <[email protected]>
|
@BusyJay It has been patched but 0.11.3 must still be restricted because 0.11.4 uses grpcio-compiler 0.6.0. And I suggest that protobuf-build use new version num like 0.12 because 0.11.3 and 0.11.4 are very different. |
|
Then patch configuration is useless. |
|
@BusyJay Why? I did see that grpcio-compiler only appeared once in Cargo.lock. Otherwise there will be two grpcio-compiler version |
|
I think whether there are two versions depends on whether protobuf-build is pinned instead of patch. Deleting patch should make no difference. |
Signed-off-by: Xintao <[email protected]>
BusyJay
approved these changes
Jul 21, 2020
hicqu
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xintao [email protected]