Allow CXX environment variable to override g++ for musl build #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David A. Ramos <[email protected]>
BusyJay
approved these changes
Nov 30, 2020
hunterlxt
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
musl-gcccross compiler doesn't come with a correspondingmusl-g++, so #195 hard-coded the C++ compiler tog++whenbuilding for musl. However, this results in building native binaries using
the native compiler, rather than an available musl toolchain (e.g.,
x86_64-linux-musl-g++).This PR modifies the build script to allow the
CXXenvironmentvariable to override
g++, even when building for musl.cc: @csssuf @Hoverbear from #195