Add user-defined checker for server side #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
hunterlxt
changed the title
Signed-off-by: Xintao <[email protected]>
|
Post the benchmark here (first is this PR, second is master): |
skyzh
previously approved these changes
Dec 15, 2020
|
This test add some logic to test |
Signed-off-by: Xintao <[email protected]>
hunterlxt
force-pushed
the
xt/add-before-executor-api
branch
from
8141467 to
4b5fa1c
Compare
|
It seems this library is missing a middleware implementation. This patch is a very limited form of middleware where an abort can be called. The way to make it more of a full middleware is to pass the checker the payload and to allow it to modify the payload (sometimes this is achieved by passing a new payload on to a handler continuation function). |
|
This seems like a good enough solution until we take the time to create a proper middleware interface. |
yiwu-arbug
reviewed
Dec 16, 2020
| let _ = client.say_hello(&req).unwrap(); | ||
| let _ = client.say_hello(&req).unwrap(); | ||
|
|
||
| flag_2.store(true, Ordering::Relaxed); |
There was a problem hiding this comment.
should use SeqCst order for both of the atomic operations.
There was a problem hiding this comment.
Address comment, BTW any ordering used here is correct.
There was a problem hiding this comment.
My mistake, if not use SeqSct, flag_2.store(true, Ordering::Relaxed); maybe be reordered behind assert.
yiwu-arbug
previously approved these changes
Dec 16, 2020
There was a problem hiding this comment.
LGTM, but I'm not familiar with grpc-rs. @BusyJay can you take a look?
Signed-off-by: Xintao <[email protected]>
BusyJay
reviewed
Dec 17, 2020
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
|
leave some test results with trait object version FYI:
|
BusyJay
reviewed
Dec 17, 2020
Signed-off-by: Xintao <[email protected]>
BusyJay
approved these changes
Dec 17, 2020
|
I do prefer a complete interceptor implementation. But I'm also OK with current design. |
gregwebs
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can provide custom checker to decide if the grpc call should be aborted in advance or be continued. For operations like check common name, a lot of redundant code can be avoided.
How to implement?
Execute the custom closure provided by the user at the
executefunction fromsrc/call/server.rs. If the user declares that the grpc call has been aborted, then skip the subsequent grpc handler.Signed-off-by: Xintao [email protected]