grpc-sys: detect failure early #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc c core 1.35 requires gcc 4.9+. It usually makes users switch compiler on failure. But cmake doesn't work well on compiler changes, so this pr detects the changes early and remove stale cache so that it can finish compilation. Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
sticnarf
approved these changes
Mar 2, 2021
hunterlxt
approved these changes
Mar 2, 2021
|
I believe rust-rocksdb also has the same problem. /cc @yiwu-arbug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc c core 1.35 requires gcc 4.9+. It usually makes users switch
compiler on failure. But cmake doesn't work well on compiler changes, so
this pr detects the changes early and remove stale cache so that it can
finish compilation.