Use default-features=false on libz-sys to allow for zlib-ng #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libz-sys enables the stock-zlib feature by default, which forces using stock zlib and prevents using zlib-ng in compat mode. Disable default-features, to allow the user of grpcio to determine what zlib implementation to use. Signed-off-by: Josh Triplett <[email protected]>
joshtriplett
force-pushed
the
libz-sys-no-default-features
branch
from
cda331b to
f687566
Compare
BusyJay
approved these changes
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libz-sys enables the stock-zlib feature by default, which forces using
stock zlib and prevents using zlib-ng in compat mode. Disable
default-features, to allow the user of grpcio to determine what zlib
implementation to use.