Skip to content

*: support querying channelz #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2021
Merged

*: support querying channelz #550

merged 3 commits into from
Oct 13, 2021

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Oct 1, 2021

This is a basic support for channelz that allows querying the
information using APIs. Full support is difficult because no library
supports parse JSON to protobuf in Rust.

This is a basic support for [channelz][1] that allows querying the
information using APIs. Full support is difficult because no library
supports parse JSON to protobuf in Rust.

[1]: https://github.com/grpc/proposal/blob/master/A14-channelz.md

Signed-off-by: Jay Lee <[email protected]>
@BusyJay BusyJay requested review from hunterlxt and NingLin-P October 1, 2021 16:41
@BusyJay
Copy link
Member Author

BusyJay commented Oct 1, 2021

@NingLin-P This can be helpful for analyzing why there are so many connections.

Copy link
Member

@hunterlxt hunterlxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Do implementations of other languages support returning content in proto format directly? If not i think the current PR is OK

@BusyJay
Copy link
Member Author

BusyJay commented Oct 8, 2021

...Do implementations of other languages support returning content in proto format directly?

Yes, they have reflections and support converting between formats.

Copy link
Member

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BusyJay BusyJay enabled auto-merge (squash) October 12, 2021 13:30
//! Channelz provides channel level debug information. In short, There are four types of
//! top level entities: channel, subchannel, socket and server. All entities are
//! identified by an positive unique integer, which is allocated in order. For more
//! explanation, see https://github.com/grpc/proposal/blob/master/A14-channelz.md.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link here is broken.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine on my laptop, perhaps you included the last comma xxx/A14-channelz.md.?

@BusyJay
Copy link
Member Author

BusyJay commented Oct 13, 2021

According to https://www.githubstatus.com/, windows action is not available right now. Since all other jobs pass, merge it now.

@BusyJay BusyJay disabled auto-merge October 13, 2021 10:47
@BusyJay BusyJay merged commit 5770690 into tikv:master Oct 13, 2021
@BusyJay BusyJay deleted the expose-channelz branch October 13, 2021 10:47
christian-oudard pushed a commit to mobilecoinofficial/grpc-rs that referenced this pull request Oct 20, 2021
This is a basic support for [channelz][1] that allows querying the
information using APIs. Full support is difficult because no library
supports parse JSON to protobuf in Rust.

[1]: https://github.com/grpc/proposal/blob/master/A14-channelz.md

Signed-off-by: Jay Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants