-
Notifications
You must be signed in to change notification settings - Fork 257
*: support querying channelz #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a basic support for [channelz][1] that allows querying the information using APIs. Full support is difficult because no library supports parse JSON to protobuf in Rust. [1]: https://github.com/grpc/proposal/blob/master/A14-channelz.md Signed-off-by: Jay Lee <[email protected]>
@NingLin-P This can be helpful for analyzing why there are so many connections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Do implementations of other languages support returning content in proto format directly? If not i think the current PR is OK
Yes, they have reflections and support converting between formats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
//! Channelz provides channel level debug information. In short, There are four types of | ||
//! top level entities: channel, subchannel, socket and server. All entities are | ||
//! identified by an positive unique integer, which is allocated in order. For more | ||
//! explanation, see https://github.com/grpc/proposal/blob/master/A14-channelz.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link here is broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine on my laptop, perhaps you included the last comma xxx/A14-channelz.md.
?
According to https://www.githubstatus.com/, windows action is not available right now. Since all other jobs pass, merge it now. |
This is a basic support for [channelz][1] that allows querying the information using APIs. Full support is difficult because no library supports parse JSON to protobuf in Rust. [1]: https://github.com/grpc/proposal/blob/master/A14-channelz.md Signed-off-by: Jay Lee <[email protected]>
This is a basic support for channelz that allows querying the
information using APIs. Full support is difficult because no library
supports parse JSON to protobuf in Rust.