Skip to content

Reduce dependency on futures crate #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Conversation

robjtede
Copy link
Contributor

@robjtede robjtede commented Dec 29, 2021

Reduces dependency graph of each crate:

before after
grpcio 50 30
benchmark 120 102
grpcio-compiler 2 2
grpcio-health 54 35
interop 71 51
grpcio-proto 54 33
tests-and-examples 63 57

A particularly important change has been made to the compiler crate which now references the Future trait directly from std rather than it's re-export through the futures crate, meaning that downstream crates can also move away from having a direct dependency on futures.

@robjtede robjtede force-pushed the fut-dep-red branch 3 times, most recently from d0b3f75 to 89da210 Compare December 29, 2021 06:18
@robjtede robjtede marked this pull request as ready for review December 29, 2021 06:19
BusyJay
BusyJay previously approved these changes Dec 29, 2021
Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BusyJay BusyJay merged commit 472ae8a into tikv:master Dec 30, 2021
@robjtede robjtede deleted the fut-dep-red branch December 30, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants