-
Notifications
You must be signed in to change notification settings - Fork 257
*: bump 0.10.0 #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: bump 0.10.0 #559
Conversation
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
$ python3 tools/run_tests/run_performance_tests.py -l rust | ||
``` | ||
|
||
Checkout `python2.7 tools/run_tests/run_performance_tests.py --help` to see custom options. | ||
Checkout `python3 tools/run_tests/run_performance_tests.py --help` to see custom options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grpc has upgraded to python3. See grpc/grpc#27135.
@@ -18,11 +18,11 @@ protobuf-codec = ["grpcio/protobuf-codec", "protobuf-build/grpcio-protobuf-codec | |||
prost-codec = ["prost-derive", "prost-types", "bytes", "lazy_static", "grpcio/prost-codec", "prost", "protobuf-build/grpcio-prost-codec"] | |||
|
|||
[dependencies] | |||
grpcio = { path = "..", features = ["boringssl"], version = "0.9.0", default-features = false } | |||
grpcio = { path = "..", features = ["boringssl"], version = "0.10.0", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like all local libs can be used without specifying a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless they need to be published to crates.io.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, tests-and-examples
dont need be published to crates.io so the version can be ignored.
No description provided.