Skip to content

*: bump 0.10.0 #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2022
Merged

*: bump 0.10.0 #559

merged 2 commits into from
Mar 2, 2022

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Mar 2, 2022

No description provided.

Signed-off-by: Jay Lee <[email protected]>
@BusyJay BusyJay requested a review from hunterlxt March 2, 2022 06:58
Copy link
Member

@hunterlxt hunterlxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Comment on lines +29 to +32
$ python3 tools/run_tests/run_performance_tests.py -l rust
```

Checkout `python2.7 tools/run_tests/run_performance_tests.py --help` to see custom options.
Checkout `python3 tools/run_tests/run_performance_tests.py --help` to see custom options.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for the change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grpc has upgraded to python3. See grpc/grpc#27135.

@@ -18,11 +18,11 @@ protobuf-codec = ["grpcio/protobuf-codec", "protobuf-build/grpcio-protobuf-codec
prost-codec = ["prost-derive", "prost-types", "bytes", "lazy_static", "grpcio/prost-codec", "prost", "protobuf-build/grpcio-prost-codec"]

[dependencies]
grpcio = { path = "..", features = ["boringssl"], version = "0.9.0", default-features = false }
grpcio = { path = "..", features = ["boringssl"], version = "0.10.0", default-features = false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all local libs can be used without specifying a version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless they need to be published to crates.io.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, tests-and-examples dont need be published to crates.io so the version can be ignored.

@BusyJay BusyJay merged commit ccd0fde into tikv:master Mar 2, 2022
@BusyJay BusyJay deleted the bump-0.10.0 branch March 2, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants