Skip to content

feat: Add support for GRPC_ARG_ENABLE_HTTP_PROXY parameter #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

feat: Add support for GRPC_ARG_ENABLE_HTTP_PROXY parameter #573

wants to merge 0 commits into from

Conversation

keskydi
Copy link
Contributor

@keskydi keskydi commented May 24, 2022

Add the support for the GRPC_ARG_ENABLE_HTTP_PROXY parameter in order to communicate between local processes

Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You need to sign off your commit.

src/channel.rs Outdated
@@ -295,6 +295,15 @@ impl ChannelBuilder {
);
self
}

/// If set to zero, disables use of http proxies.
pub fn enable_http_proxy(mut self, num: i32) -> ChannelBuilder {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using bool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modification done

BusyJay
BusyJay previously approved these changes May 25, 2022
@BusyJay
Copy link
Member

BusyJay commented May 25, 2022

You can use command git commit --signoff to signoff your commits. Note all commits need to be signed off.

@keskydi
Copy link
Contributor Author

keskydi commented May 25, 2022

Had trouble with signing so i ended up doing another pull request : #575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants