*: update prost to 0.11 #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 0.11, prost-build never bundles protoc binary anymore. To avoid requiring protoc for grpcio-proto users, we bundle the sources instead of generating at compile time. This can lead to potential problems like: - Miss match version between generating tools and runtime - Repository becomes bloated But there seems to be no better alternative. Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
sticnarf
reviewed
Nov 1, 2022
| @@ -443,3 +443,5 @@ pub fn file_descriptor_proto() -> &'static ::protobuf::descriptor::FileDescripto | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| pub use super::health_grpc::*; | |||
There was a problem hiding this comment.
I'm curious about the small structure change. Is this line added by hand?
There was a problem hiding this comment.
sticnarf
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 0.11, prost-build never bundles protoc binary anymore. To avoid requiring protoc for grpcio-proto users, we bundle the sources instead of generating at compile time. This can lead to potential problems like:
But there seems to be no better alternative.
Since this PR when using prost with grpcio, protoc is also required in PATH.
This PR also removes protobuf-build dependencies. From now on, it will be easier to publish new version of grpcio-compiler.
Close #545.