Skip to content

Fix handling of integers in AutoIntParamType #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

mryab
Copy link
Member

@mryab mryab commented Oct 18, 2024

The current implementation of AutoIntParamType.convert returns integers only when integers are passed as value. However, value is defined as a string, so this branch of the code never gets used. As a result, passing --batch-size 16 (or any other integer) to the command for creating jobs fails with the following error:

Error: Invalid value for '--batch-size': Invalid integer value: {value}

This PR fixes that error, moving over the code to handle integer inputs correctly from Click

@mryab mryab changed the title Fix auto param type Fix handling of integers in AutoIntParamType Oct 18, 2024
@orangetin orangetin merged commit 2a96da0 into main Oct 18, 2024
13 checks passed
@orangetin orangetin deleted the fix_auto_param_type branch October 18, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants