Skip to content

Hotfix: remove DPO hyperparameter validations #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

sbassam
Copy link
Contributor

@sbassam sbassam commented Jun 16, 2025

Describe your changes

This PR temporarily removes validations for some of the variables in finetune.py

@sbassam sbassam requested review from mryab and connermanuel June 16, 2025 21:08
Copy link
Member

@mryab mryab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to bump the version!

@connermanuel connermanuel changed the title Hotfix: remove validations Hotfix: remove DPO hyperparameter validations Jun 16, 2025
@sbassam sbassam merged commit 4655ead into main Jun 16, 2025
10 checks passed
@sbassam sbassam deleted the hotfix-remove-validations-temporarily branch June 16, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants