Skip to content
This repository was archived by the owner on Jan 5, 2024. It is now read-only.

Large Numbers give incorrect results #13

Closed
flarpy opened this issue Sep 25, 2019 · 3 comments · Fixed by #14
Closed

Large Numbers give incorrect results #13

flarpy opened this issue Sep 25, 2019 · 3 comments · Fixed by #14

Comments

@flarpy
Copy link

flarpy commented Sep 25, 2019

$converter = new Converter("pounds", "pence");
$converter->convert(50000000)

should return "Fifty million pounds Only"
actually returns "Fifty Million, Thousand, Pounds Only"

@toksdotdev
Copy link
Owner

Thanks @flarpy for identifying the issue. I'll look into it immediately.

@toksdotdev
Copy link
Owner

@flarpy This has been fixed in the latest release: v2.0.1.

Thanks a lot for bringing the issue to notice.

@flarpy
Copy link
Author

flarpy commented Sep 25, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants