Skip to content

Add .uuid field to Log class #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2020
Merged

Add .uuid field to Log class #152

merged 3 commits into from
Jul 12, 2020

Conversation

pkubiak
Copy link
Contributor

@pkubiak pkubiak commented Jul 3, 2020 •
edited
Loading

I have extended Log class with .uuid field - unique (server side) log identifier. It can be used for identifing and storing logs.

Note: If it is possible, please perform Squash merge type.

@coveralls
Copy link

coveralls commented Jul 3, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 94.938% when pulling 5b79b21 on pkubiak:feature-log-uuid into ab3f3f1 on tomasbedrich:master.

FriedrichFroebel
FriedrichFroebel approved these changes Jul 3, 2020
View reviewed changes
Copy link
Collaborator

@FriedrichFroebel FriedrichFroebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FriedrichFroebel FriedrichFroebel merged commit 02a3951 into tomasbedrich:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriedrichFroebel FriedrichFroebel FriedrichFroebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkubiak @coveralls @FriedrichFroebel