Skip to content

Get logged user from JS #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 14, 2021
Merged

Get logged user from JS #163

merged 6 commits into from
Nov 14, 2021

Conversation

tomasbedrich
Copy link
Owner

Close #162

FriedrichFroebel
FriedrichFroebel requested changes Apr 24, 2021
View reviewed changes
Copy link
Collaborator

@FriedrichFroebel FriedrichFroebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to fail as the cassettes have not yet been updated. We should probably do this before merging to verify the correct behaviour. Besides this, the fix looks good to me.

@tomasbedrich
Copy link
Owner Author

You are right. I was struggling with some errors in tests, when I simply deleted the cassettes and re-recorded them. Currently, I am busy at work so if you have more time, feel free to contribute by fixing (at least some) of tests. Otherwise, I can probably fix it next weekend.

@tomasbedrich tomasbedrich force-pushed the fix-get-logged-user branch from ef6826a to 4e44041 Compare May 1, 2021 23:36
@FriedrichFroebel
Copy link
Collaborator

I just fixed the obvious errors from the test run, which leaves one failing test. As I am currently short of time, I have not made an attempt to take a deeper look at it.

Additional notes:

  • Travis states that it will shutdown tomorrow:

    Hi! It seems there are still plenty of builds running. We're pushing back the shutdown date to June 15th. Please consider migrating to travis-ci.com.

    We should probably migrate the CI stuff in the near future, maybe directly to GitHub Actions.

  • The regex match access fix seems to be required for Python 3.5 only which already is EOL. So we might consider dropping it and reverting the change.

@FriedrichFroebel FriedrichFroebel mentioned this pull request Nov 12, 2021
Closed
@tomasbedrich
Start migration to new pytest based test structure
8372722 
- migrate build system to Flit
- migrate CI to GitHub Actions
- update CONTRIBUTING guide
- fix login tests
- re-record all cassettes
- other refactoring
@tomasbedrich tomasbedrich mentioned this pull request Nov 14, 2021
Merged
@tomasbedrich
Merge pull request #167 from tomasbedrich/testing-overhaul
fe1c4df 
Start migration to new pytest based test structure
@tomasbedrich tomasbedrich merged commit 447e753 into master Nov 14, 2021
@tomasbedrich tomasbedrich deleted the fix-get-logged-user branch November 14, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriedrichFroebel FriedrichFroebel FriedrichFroebel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login at geocaching.com doesn't work anymore
2 participants
@tomasbedrich @FriedrichFroebel