Fix and improve Geocaching.search_rect()
#203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Could you please add a test for the reverse sort order as well? Additionally, I am not sure whether we should stay with the lowercase ordering values when calling the API or really switch to the capitalized version as in this PR. |
As I'm thinking about this now, I think we should stay with the lowercase ordering values, as the "official" requests use the lowercase. Updated in 08f6831. |
Sure, I added it right now in 14db0c7. Is it fine? |
FriedrichFroebel
requested changes
Jan 12, 2023
FriedrichFroebel
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can pass parameters for reversing and limiting the returned caches directly to the URL requested by
Geocaching.search_rect(), I believe it would be helpful (at least for me) to have these parameters accessible in Python code.I also fixed the parsing of the
userFoundproperty because the returned data format has changed a bit.And, of course, I reloaded the test cartridges to reflect recent changes.