Skip to content

General frontend tweaks (lazy load CTA images and styling updates) #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2025

Conversation

shyusu4
Copy link
Collaborator

@shyusu4 shyusu4 commented Apr 9, 2025

Tickets:

Description of Changes Made

  • On large screens a 'featured services' block with 4+ cards will now use a smaller heading to prevent text overflow
  • Update the Torchbox Public-logo height
  • Fix layout of the desktop submenu to match the design
  • Lazy-load CTA images: footer CTA avatar and contact CTA avatar

How to Test

Navigate throughout your local build and view the relevant pages:
http://localhost:8000/wagtail/
http://localhost:8000/public-sector/

Screenshots

Expand to see more

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@shyusu4 shyusu4 changed the title General frontend tweaks General frontend tweaks (lazy load CTA images and styling updates) Apr 9, 2025
@shyusu4 shyusu4 marked this pull request as ready for review April 9, 2025 14:09
Copy link
Member

@helenb helenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sherry for looking at all these different tweaks. I've spotted a few things that need updating.

Copy link
Member

@helenb helenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a final test of the header styling for featured services, but I'm happy to approve as long as you have tested and it is behaving as expected. Nice work.

@shyusu4 shyusu4 merged commit 36444b3 into main Apr 14, 2025
4 checks passed
@shyusu4 shyusu4 deleted the fix/frontend-tweaks branch April 14, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants