-
Notifications
You must be signed in to change notification settings - Fork 3
General frontend tweaks (lazy load CTA images and styling updates) #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sherry for looking at all these different tweaks. I've spotted a few things that need updating.
tbx/project_styleguide/templates/patterns/molecules/footer-cta/footer-cta.html
Show resolved
Hide resolved
...oject_styleguide/templates/patterns/molecules/streamfield/blocks/contact_call_to_action.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a final test of the header styling for featured services, but I'm happy to approve as long as you have tested and it is behaving as expected. Nice work.
Tickets:
Description of Changes Made
How to Test
Navigate throughout your local build and view the relevant pages:
http://localhost:8000/wagtail/
http://localhost:8000/public-sector/
Screenshots
Expand to see more
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library