added alpha scaling in expnorm and visualization function #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav0dea
requested changes
Jul 19, 2021
|
Good point! I will change it and commit soon. |
|
Ok I think it should work now - let me know if you need any more more changes. |
dav0dea
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds the "alpha scaling" described in #28. The parameter is chosen directly from the upper and lower cutoffs only, so it should work with the normal basis function flow that the model initialization currently uses. I also added a utility function,
visualize_basisthat helps visualize gaussian or expnormal bases for debugging purposes. Let me know if there are any changes needed or things to add/remove.