Skip to content

testing: Remove deprecation warning filter for set_event_loop #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

bdarnell
Copy link
Member

@bdarnell bdarnell commented May 8, 2025

The deprecation warning for this function was reverted for 3.14b1.

See python/cpython#130322

The deprecation warning for this function was reverted for 3.14b1.

See python/cpython#130322
@bdarnell
Copy link
Member Author

bdarnell commented May 8, 2025

This runs into tox-dev/tox#3523. We'll need either a fix for tox or wait for beta2 from cpython.

@bdarnell bdarnell force-pushed the undeprecate-set-event-loop branch from d5b0689 to 3fd0e5d Compare May 12, 2025 17:55
@bdarnell
Copy link
Member Author

That last commit is a false CI success. I thought I had worked out the magic to use two different python versions with tox but it's still not doing the right thing. tox-dev/tox#3532

@hugovk
Copy link
Contributor

hugovk commented May 13, 2025

This runs into tox-dev/tox#3523. We'll need either a fix for tox or wait for beta2 from cpython.

This has been fixed and released in tox: https://github.com/tox-dev/tox/releases/tag/4.26.0 (and will also be fixed in beta2).

This resolves a conflict between older versions of tox and
Python 3.14b1.
@bdarnell bdarnell force-pushed the undeprecate-set-event-loop branch from 3fd0e5d to c3d906c Compare May 13, 2025 16:24
@bdarnell bdarnell merged commit 197ff13 into tornadoweb:master May 13, 2025
15 checks passed
@bdarnell bdarnell deleted the undeprecate-set-event-loop branch May 13, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants