Skip to content

feat: Update OG title and description from pagedata #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

milooy
Copy link
Collaborator

@milooy milooy commented Jan 14, 2025

image image image

Since there are only title and description in the meta data,
Kakaotalk does not render description on the sharing card.

Push meta data from pageData

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-fundamentals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 6:04am

@raon0211
Copy link
Contributor

image

Maybe our vitepress build is failing?

@milooy
Copy link
Collaborator Author

milooy commented Jan 14, 2025

Yeah, it's actually a problem in the code.
Please wait for the fix commit

@milooy milooy changed the title feat: update og from pagedata feat: Update og from pagedata Jan 14, 2025
@milooy milooy changed the title feat: Update og from pagedata feat: Update OG title and description from pagedata Jan 14, 2025
@milooy milooy merged commit 5982b57 into main Jan 14, 2025
2 checks passed
raon0211 pushed a commit that referenced this pull request Jan 14, 2025
* feat: update og from pagedata

* fix: give default value to title and description
raon0211 pushed a commit that referenced this pull request Jan 14, 2025
* feat: update og from pagedata

* fix: give default value to title and description
raon0211 pushed a commit that referenced this pull request Jan 14, 2025
* feat: update og from pagedata

* fix: give default value to title and description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants