Skip to content

fix: Remove unnecessary vertical scrollbar and improve the example with tab format in "Rendering Arrays with Specific Separators" section #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

umsungjun
Copy link

Overview

This PR remove unnecessary vertical scrollbar and improve the example with tab format in "Rendering Arrays with Specific Separators" section

  • Fixed the issue causing an unwanted vertical scrollbar to appear on the right side of the code block.
  • Refactored the example code by separating without-react-simplikit.tsx and with-react-simplikit.tsx into tabs for better readability.

Before
스크린샷 2025-04-15 오전 10 15 38

After
스크린샷 2025-04-15 오전 10 15 59

Checklist

  • Did you write the test code?
  • Have you run yarn test:coverage to make sure there is no uncovered line?
  • Did you write the JSDoc?

…Separators" example

This PR removes the unnecessary vertical scrollbar in the example code within the Rendering Arrays with Specific Separators section.

- Fixed the issue causing an unwanted vertical scrollbar to appear on the right side of the code block.
- Refactored the example code by separating without-react-simplikit.tsx and with-react-simplikit.tsx into tabs for better readability.
@Copilot Copilot AI review requested due to automatic review settings April 15, 2025 01:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/docs/ko/intro.md:54

  • Both code blocks within the code-group use the same file label 'without-react-simplikit.tsx'. If they are meant to demonstrate different examples (e.g., with and without simplikit), consider updating one of the labels for greater clarity.
```tsx [without-react-simplikit.tsx]

src/docs/en/intro.md:54

  • Both code blocks within the code-group use the same file label 'without-react-simplikit.tsx'. If they are intended to represent different scenarios, consider updating one of the labels for improved clarity.
```tsx [without-react-simplikit.tsx]

Copy link

vercel bot commented Apr 15, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@seungrodotlee
Copy link
Member

Initially, it was implemented as a toggle.

However, there was feedback that showing the before-and-after in a single view would better illustrate the code improvements.

Therefore, the current version of the view was selected.

@seungrodotlee
Copy link
Member

By the way, I noticed that I should fix gradient in dark mode by this PR...
Thanks!

@umsungjun
Copy link
Author

@seungrodotlee

Thank you very much for the valuable feedback.
However, considering consistency with other pages, I carefully wonder if separating the views into tabs—like the previous version—might be more appropriate.

@umsungjun
Copy link
Author

Alternatively, would it be okay if I re-submit the PR with vertical titles instead?

@seungrodotlee
Copy link
Member

I have fix SplitView component in #173
and want to hear your opion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants