-
Notifications
You must be signed in to change notification settings - Fork 602
[WIP] Run clippy fix on clippy::pedantic errors #3206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (71.89%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3206 +/- ##
==========================================
- Coverage 82.22% 82.08% -0.14%
==========================================
Files 962 963 +1
Lines 122572 122762 +190
==========================================
- Hits 100779 100769 -10
- Misses 21793 21993 +200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
28239b9
to
15a97de
Compare
This PR has been marked as stale because it has not been updated for over a month |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly seems to fix more aggressive clippy lints along with typos / formatting in docstrings. Not entirely against, though I feel some lints are probably more opiniated than anything so we might have to be careful.
One thing I am not sure about is the usage of #[must_use]
. I also think its usage should be informed to indicate specific types that are "important" (e.g., results that should not be ignored, or types with custom drop implementation). In other words, this is more advice to the usage than anything. I did not review the whole set of changes, but the few additions of must_use
seemed to make sense at first glance.
@crutcher did you actually want to go through with some of these suggestions, or were you mostly fiddling with the lints? In other words, should this be closed or not 😅 )
I think most of these suggestions are good ideas; and I'd like to move forward by turning on specific extra lints, one at a time, and fixing them. |
Checklist
cargo run-checks
command has been executed.Changes
This sits on top of #3200
I enabled
pedantic = "deny"
; rancargo clippy --fix
; then disabled and cleaned up.