Use Virtual Threads when applicable #25855
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any measurable benefits? Data please :) |
|
@losipiuk it's hard to quantify - this will use less resources but we do not track threads in the memory accounting |
raunaqmorarka
approved these changes
May 23, 2025
sajjoseph
reviewed
May 23, 2025
| @@ -109,7 +108,7 @@ public void setup(Binder binder) | |||
|
|
|||
| newOptionalBinder(binder, Key.get(ExecutorService.class, ForJdbcClient.class)) | |||
| .setDefault() | |||
| .toInstance(newCachedThreadPool(daemonThreadsNamed(format("%s-jdbc-client-%%d", catalogName)))); | |||
| .toInstance(newThreadPerTaskExecutor(virtualThreadsNamed(catalogName + "-jdbc-client-#%s"))); | |||
There was a problem hiding this comment.
nit:
format("%s-jdbc-client-#%s", catalogName)
|
Started benchmark workflow for this PR with test type =
|
This is mostly I/O intensive (reading JARs)
wendigo
force-pushed
the
serafin/virtual-threads
branch
from
bcbeae0 to
0678d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: