-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add 476 release notes #25865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 476 release notes #25865
Conversation
6cc8ebc
to
8c95d48
Compare
procedure. ({issue}`25666`) | ||
* Fix query failures when attempting to read `date` columns stored as integer | ||
values in Parquet files. ({issue}`25667`) | ||
* Fix `SHOW SCHEMAS` failure when catalog names contain mixed case letters. ({issue}`25701`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think SHOW SCHEMAS
was just an example of query which failed. The actual class of failed queres was larger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the class of queries affected? Or is it essentially any query that needs to read from such catalog?
Also, I see this affects only FileCatalogStore. So, only when using dynamic catalogs? cc @kokosing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. I focused on SHOW SCHEMA
because that was the problem that was escalated to me. There could other examples and many of them can be sourced from ShowQueriesRewrite
. Tracking exactly all the exposure might be challenging as we often do toLowerCase
.
So, only when using dynamic catalogs?
Yes. I did take a look now after you asked on StaticCatalogManager
and I am under impression it may behave the same way. Let me check.
* Fix query failure when reading ORC files with a large row count. ({issue}`25634`) | ||
* Reduce S3 throttling failures by increasing streaming upload part size and reducing | ||
number of requests. ({issue}`25781`) | ||
* Fix query timeout errors due to concurrent writes on tables with large number of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raunaqmorarka what writes
mean hear. Looks like the PR is about some lock contention, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writes in iceberg update some metadata at the end in the coordinator, this operation was earlier using the same threadpool as the one used by query planning and blocking those if the write was large enough. Now we separated the threadpool for query planning.
Let me know when this needs another look @martint |
c7b4bdf
to
132a5a3
Compare
@mosabua , can you do a final pass and approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things but essentially good to go.
* Make soft memory limit optional in resource groups. ({issue}`25916`) | ||
* Remove the [](/develop/example-http) from the tar.gz archive and the Docker container. ({issue}`25128`) | ||
* Fix rare bug when server can hang under load. ({issue}`25816`) | ||
* Fix regression introduce in Trino 474 that prevented graceful shutdown from working. ({issue}`25690`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a note in the 474 and 475 rn to warn about that? Could be in a follow up PR.
* Add support for excluding certain tables from the directory listing cache | ||
with the `hive.file-status-cache.excluded-tables` configuration property. ({issue}`25715`) | ||
* Allow selecting the AWS signing protocol to use when authenticating S3 requests. ({issue}`25820`) | ||
* Improve compatibility with S3-compliant storage systems. ({issue}`25791`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need details here or in docs?
No description provided.