-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/md typedoc #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/md typedoc #304
Conversation
Allows to render typedoc documentation in markdown.
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=======================================
Coverage 62.55% 62.55%
=======================================
Files 19 19
Lines 1199 1199
Branches 226 226
=======================================
Hits 750 750
Misses 387 387
Partials 62 62
Continue to review full report at Codecov.
|
What is the state of this PR? Since it is the last one that blocks the big story of trustlines-network/project#798 |
Do we really want to add the generated markdown files to git? |
I also don't like too much to have sources and generated products in a repo. The problem is that we need that for the centralized dev-docu repo which will fetch the |
Yes definitely is a lot of clutter the auto-generated md files... I like the dedicated branch approach @weilbith mentioned. So shall I clean up the PR by removing the respective files and only leaving the not auto-generated files and changes in? |
This PR includes the API reference for the clientlib which is auto-generated using typedoc from the comments within the source code. The plugin https://github.com/tom-grey/typedoc-plugin-markdown is used to generate the documentation as md files.
As we only want to expose the most important APIs to the user, I tried to find a way to "whitelist" specific methods/classes with typedoc but failed to do so without having to refactor the whole library. So, for now, I added a table of contents file in
./docs/api-reference-index.md
where we can refer to the classes that should be part of the documentation. All auto-generated files from typedoc are saved under./docs/api
. If you guys have another suggestion on how to make this better, please let me know.