Add support for Django Rest Framework 3.9 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuffnatty Anything missing from this PR for it to get merged? The failed build seems to be a travis error, not an error in with the code |
|
The failing builds are fixed in #5 |
OskarPersson
changed the title
|
I've merged the changes in #5 with this PR to fix more builds. I've also added more Python, Django and DRF versions. Python 3.3 is the only thing failing now, not sure how to solve it. Maybe drop support for it since it is an old and unsupported release? I'm also not sure why the travis status is not updated here for the new commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django Rest Framework (DRF) has in 3.9.0 (encode/django-rest-framework#5605) made a change where it now uses a
mappingattribute when looking for actions of a view. This collides with themappingattribute inProxyPaginationwhich I've now renamed topager_mapping.I've also updated the travis and tox configurations to include more Django and DRF versions.