Fix failure to validate exception messages #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous use of strings instead of regular expressions caused the assertion to treat the message as an additional output string should the test function fail to throw. Switching to RegExp causes the assertion to instead validate the error message itself. See nodejs/node#19867
sharwell
force-pushed
the
validate-errors
branch
from
49314eb to
7d8dca7
Compare
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
=======================================
Coverage 74.89% 74.89%
=======================================
Files 152 152
Lines 10058 10058
Branches 1587 1587
=======================================
Hits 7533 7533
Misses 1966 1966
Partials 559 559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous use of strings instead of regular expressions caused the assertion to treat the message as an additional output string should the test function fail to throw. Switching to RegExp causes the assertion to instead validate the error message itself.
See nodejs/node#19867