Drop Adelle Sans for Open Sans #359
Conversation
|
Good idea. |
| <!-- Roboto --> | ||
| <link rel="stylesheet" href="http://fonts.googleapis.com/css?family=Roboto:400,500,700"> | ||
| <!-- Google Web Fonts --> | ||
| <link rel="stylesheet" href="http://fonts.googleapis.com/css?family=Roboto:400,500,700&Source+Sans+Pro:300,400,600,700"> |
There was a problem hiding this comment.
https://developers.google.com/fonts/docs/getting_started#Syntax says to use | as separator between multiple fonts.
|
Yeah, I like Adelle as a font better but this is clearly a win. |
|
I've switched this PR to use Open Sans because Source Sans Pro is rather short compared to both fallback fonts and the current Adelle Sans. It'd require a lot of I've also made some other modifications here:
Still have a few tweaks to make given the font change, but overall it's pretty on par with what we're rocking today, minus 300kb still.
|
|
🆒 so I went through and took care of merging master. I also updated the examples page to be a bit simpler and use the grid. Speaking of the grid, I simplified that too. I went ahead and got rid of the extra padding as the screens got bigger. I really didn't like it that much and it made the examples look bad. |
|
👍 for Open Sans |
| <!-- Roboto --> | ||
| <link rel="stylesheet" href="http://fonts.googleapis.com/css?family=Roboto:400,500,700"> | ||
| <!-- Google Web Fonts --> | ||
| <link rel="stylesheet" href="http://fonts.googleapis.com/css?family=Roboto:400,500,700|Open+Sans:300"> |
There was a problem hiding this comment.
Perhaps just use the protocol relative URL here?
Conflicts: docs/_includes/header.html docs/getting-started.html sass/docs.scss
…timize_docs_fonts Conflicts: docs/examples.html docs/getting-started.html sass/docs.scss
|
✨ |
|
@zdroid Already merged. |
|
@connors You merged the pull request before I sent the comment, lol! ⏩ ⏩ ⏩ |
I'm proposing we drop Adelle Sans and use Source Sans Pro from Google Web Fonts. Apparently this shaves 300kb off the docs file size, a huge win for #354. Plus, rather than
font-weight: 100everywhere in media queries, we stick to one font weight, no matter the screen. This means nullifying #351.Visually, they look pretty similar to me, and that page load is huge.
Before
After