Rename angle.spheric.top to angle.spheric.t #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current name was inconsistent with our naming scheme.
There's also a broader discussion to be had whether all the
.rev
variants we have make sense. If there is a "canonical" direction, such as forin
, then yes, but I have no idea what to expect forangle.spheric
. It would better to use names likeangle.spheric.r
,angle.spheric.l
andangle.spheric.t
to indicate which way it opens.I didn't make that change, but the same comment applies to
angle.rev
,angle.right.rev
, andangle.arc.rev