Umbraco 15: Javascript error in blocklist when switching to settings tab

[cg-hurst]

Which Umbraco version are you using?

15.3.0

Bug summary

When switching between the content and settings tabs in the blocklist sidebar, a javascript error is thrown, occasionally causing the dialog not to update. The error is:

Uncaught RangeError: Maximum call stack size exceeded
at UmbContextProviderController.destroy (context-provider.controller.js:26:12)
at et.destroy (validation.controller.ts:310:23)
at UmbContextProviderController.destroy (context-provider.js:88:34)
at UmbContextProviderController.destroy (context-provider.controller.js:32:15)
at et.destroy (validation.controller.ts:310:23)
at UmbContextProviderController.destroy (context-provider.js:88:34)
at UmbContextProviderController.destroy (context-provider.controller.js:32:15)
at et.destroy (validation.controller.ts:310:23)
at UmbContextProviderController.destroy (context-provider.js:88:34)
at UmbContextProviderController.destroy (context-provider.controller.js:32:15)

Specifics

This happens in the backoffice when editing a blocklist's block in a modal. Clicking on the Content or Settings tabs throws a javascript error.

Steps to reproduce

1. Install a fresh Umbraco 15.3.0 instance
2. Create Text Block element content type
3. Add an RTE field called Text
4. Create a Text Block Settings element content type
5. Add a true/false type called Enabled
6. Create a Templated Content Type called Home Page
7. Add a Block list to the Home Page. Add the Text Block to the list of blocks and the Text Block Settings as it's settings.
8. Allow Home Page at root
9. Navigate to the content tab and create a Home Page. Add the text block and switch between Content and Settings.

Expected result / actual result

Expected: No javascript error expected.

Actual: Error thrown and dialog does not update the first time the error occurs

[github-actions]

Hi there @cg-hurst!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[CodingDK]

I can confirm this - I also got this error after updating from 15.2.3 to 15.3.0 - so it's a "new bug" coming in 15.3.0.
I also can confirm that if you press the "setting"-tab 2 times - it will be showed.

[AndyButland]

I can't reproduce this in the latest code @nielslyngsoe - so could well it's been fixed. However I do see an error when you go click to Settings and then go back to Content, of the following, so it seems an issue has been introduced here too:

Uncaught Error: This Validation Context has been destroyed and can not be provided.
    at UmbValidationController.provideAt (validation.controller.ts:138:10)
    at UmbBlockElementManager.setup (block-element-manager.ts:226:19)
    at Object.next (block-workspace-view-edit.element.ts:77:19)

[AndyButland]

See also #18779

[iOvergaard]

Fixed with #18864