V15 - Not possible to await unpublish action on UmbDocumentPublishingWorkspaceContext

[kraftvaerk-chth]

Which Umbraco version are you using?

15.4.0

Bug summary

The unpublish function in UmbDocumentPublishingWorkspaceContext returns a promise, but the promise resovles almost immediately after being called, due to the last .execute() call not being awaited.

This makes it impossible to await the unpublish action on the context

Umbraco-CMS/src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts

Line 271 in 12049e9

new UmbUnpublishDocumentEntityAction(this, { unique, entityType, meta: {} as never }).execute();

Specifics

No response

Steps to reproduce

Consume the context UMB_DOCUMENT_PUBLISHING_WORKSPACE_CONTEXT
await context.Unpublish()
log something to console after.

You will see that the log appears before the user has pressed anything on the unpublish modal

Expected result / actual result

No response

---

This item has been added to our backlog AB#52804

[github-actions]

Hi there @kraftvaerk-chth!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nielslyngsoe]

This has been fixed for 16-rc2 has part of this PR:
#19285