Skip to content

Replaces System.Drawing with ImageSharp, and thereby fix TODO. #10205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2021
Merged

Replaces System.Drawing with ImageSharp, and thereby fix TODO. #10205

merged 1 commit into from
May 5, 2021

Conversation

bergmania
Copy link
Member

Details

  • Replaces System.Drawing with ImageSharp, and thereby fix TODO.

Test

  • Go to the media section and upload files of different types.
  • The following formats are supported
    • GIF : GifDecoder
    • PNG : PngDecoder
    • BMP : BmpDecoder
    • JPEG : JpegDecoder
    • TGA : TgaDecoder

@warrenbuckley
Copy link
Contributor

Code changes look fine
Will need to test this out next :)

@warrenbuckley
Copy link
Contributor

All works as expected

@warrenbuckley warrenbuckley merged commit 0bdeda3 into v9/dev May 5, 2021
@warrenbuckley warrenbuckley deleted the v9/feature/replace-system-drawing-with-imagesharp branch May 5, 2021 13:57
@ronaldbarendse
Copy link
Contributor

While working on PR #10623, I noticed we're loading the complete image into memory (by doing Image.Load(stream)) to get the width/height. ImageSharp also has an Image.Identify(stream) method that is more efficient: https://docs.sixlabors.com/articles/imagesharp/imageformats.html#metadata-only-decoding.

The PR to update this is already done: #10964 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
project/v9 release/netcore-beta002
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bergmania @warrenbuckley @ronaldbarendse