Skip to content

UI improvement: Add option to select/deselect all filters in Log Viewer drop-down #10815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jakob-bagterp
Copy link
Contributor

@jakob-bagterp jakob-bagterp commented Aug 8, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

Feature update per discussion: #10765

Description

Add select/deselect all feature to the Log Viewer.

Animation

Screenshot 2021-08-08 214227

Screenshot 2021-08-08 214247

And it also supports localisations of the button labels (Danish included in this pull request):

Screenshot 2021-08-08 214329

@umbrabot
Copy link

umbrabot commented Aug 8, 2021

Hi there @jakob-bagterp, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef
Copy link
Contributor

bjarnef commented Aug 9, 2021

It should probably add a single og two <umb-dropdown-item> as last item(s) and buttons inside here to clear and select all.

@mattbrailsford has added something similar in Vendr where a clear button is shown at bottom on one or more selection. Maybe he has some feedback as well?

@jakob-bagterp
Copy link
Contributor Author

jakob-bagterp commented Aug 9, 2021

It should probably add a single og two <umb-dropdown-item> as last item(s) and buttons inside here to clear and select all.

@bjarnef: Good point. The buttons are hereby wrapped in the <umb-dropdown-item> directive. It looks and behaves as before, and I agree that the HTML is more semantically correct now.

@jakob-bagterp jakob-bagterp changed the title UI improvement: Add option to select/deselect all in Log Viewer drop-down UI improvement: Add option to select/deselect all filters in Log Viewer drop-down Aug 10, 2021
Copy link
Contributor

@nathanwoulfe nathanwoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakob-bagterp, this works really nicely. Extra bonus points for going to the effort of adding translations, that's greatly appreciated.

I made a couple of minor changes to use forEach and map in place of the for... loops, functionally all the same, just reduces LOC a little.

@nathanwoulfe nathanwoulfe merged commit 4dd3b81 into umbraco:v8/contrib Aug 17, 2021
@jakob-bagterp jakob-bagterp deleted the v8/feature/log-viewer-select-deselect-all branch August 17, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants