Skip to content

Changed the case of BlockList to blocklist as it breaks on Linux Mint #11219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

prjseal
Copy link
Contributor

@prjseal prjseal commented Sep 29, 2021

Changed the case of BlockList to blocklist as it breaks on Linux Mint. Thanks to @craigs100 for spotting this.

Changed the case of BlockList to blocklist as it breaks on Linux Mint. Thanks to @craigs100 for spotting this.
@umbrabot
Copy link

umbrabot commented Sep 29, 2021

Hi there @prjseal, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@glombek
Copy link
Contributor

glombek commented Oct 2, 2021

This looks good @prjseal - thanks for contributing!

I'm just wondering why these folders are lower-case to begin with while all the rest are Pascal case. Let me check if anybody knows why this is the case.

@prjseal
Copy link
Contributor Author

prjseal commented Oct 2, 2021

I don't know why. The grid folder is lowercase too. I think it would be best if all folders were lowercase personally, to be consistent and avoid errors on Linux based operating systems.

@glombek
Copy link
Contributor

glombek commented Oct 5, 2021

Thanks @prjseal, I've checked with HQ and it's staying that way. Consistency is key for avoiding issues on *nix systems. All the .NET-y bits are capitalized (as is convention) while the front-endy bits are lower case (as is convention there too!) We just need to ensure all code references to these folders follow that convention too.

So your fix looks good to go. Thanks again!

@glombek glombek self-requested a review October 5, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants