Cypress test for textbox max length

[jemayn]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Added Cypress test for testing the textbox datatype's maxlength setting.
It roughly does this:

• Creates a doctype with a new textbox datatype with max chars 10
• Creates a content node based on that and add 8 chars to the textbox - asserts no helptext occurs
• Adds another char - assert it tells the user there is only 1 char left
• Adds 2 more - asserts it now errors as we are above the limit

Also renamed the member group test group from user group to member group as that confused me a bit 😁

Let me know if anything here isn't how it should be!

PS: Runs for around 4s on my machine - could probably shave a bit off if we skipped the initial save and publish assertion, already removed the middle one as it seemed unnecessary - the final one is necessary to trigger validation errors and is also fast as it errors before the actual save & publish action runs.

[umbrabot]

Hi there @jemayn, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nathanwoulfe]

Looks good to me, thanks @jemayn. Test suite is running really slowly on my machine (at least 20 seconds per test), not sure what's going on there, but would like to see the suite run through before I merge.

Edit: it's all green in the build 😄

[nul800sebastiaan]

Cherry picked for v8 in 445f31e

[umbrabot]

Hi there @jemayn,

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 31st, 2021.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏

We have blogged about this year's hacktoberfest in a recap post, have a read about at all the achievements for this year!

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco Teams