Skip to content

Unable to correct a short invalid alias on a property #15735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Unable to correct a short invalid alias on a property #15735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 60 additions & 3 deletions tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/documentTypes.spec.ts
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,69 @@ test.describe('Document types', () => {

// This delete button for some reason does not have the usual general_delete label
await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey("delete"));

const docTypeLocator = await page.locator("text=" + name);

// Assert
await expect(docTypeLocator).toHaveCount(0);


// Clean up
await umbracoApi.documentTypes.ensureNameNotExists(name);
await umbracoApi.templates.ensureNameNotExists(name);
});

test('Correct an invalid alias for a new property on a new doc type', async ({ page, umbracoApi, umbracoUi }) => {
const name = "Test document type 2";

await umbracoApi.documentTypes.ensureNameNotExists(name);
await umbracoApi.templates.ensureNameNotExists(name);

await umbracoUi.goToSection(ConstantHelper.sections.settings);
await umbracoUi.waitForTreeLoad(ConstantHelper.sections.settings);
await umbracoUi.clickElement(umbracoUi.getTreeItem("settings", ["Document Types"]), {button: "right"})

await umbracoUi.clickElement(umbracoUi.getContextMenuAction(ConstantHelper.actions.create));
await umbracoUi.clickElement(umbracoUi.getContextMenuAction(ConstantHelper.actions.documentType));

await umbracoUi.setEditorHeaderName(name);

// Add a property group
await page.locator('[data-element="group-add"]').click();
await page.locator('.umb-group-builder__group-title-input').fill('Group name');
// Add a property
await page.locator('[data-element="property-add"]').click();
// enter a label that will generate an invalid alias
await page.locator('.editor-label').fill('A');
await page.locator('[data-element="editor-add"]').click();

// Search for textstring
await page.locator('#datatype-search').fill('Textstring');

await page
.locator('ul.umb-card-grid li [title="Textstring"]')
.locator("xpath=ancestor::li")
.click();

await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey(ConstantHelper.buttons.submit));

// ensure we got an error that our property alias was invalid
await expect(page.locator('[alias="model.property.alias"] .umb-validation-label')).toBeVisible();

// click the lock icon to change the alias
await page.locator('[alias="model.property.alias"] .umb-locked-field__toggle').click();

// change the property alias to a valid alias
await page.locator('[alias="model.property.alias"] [name="lockedField"]').fill('test');

// submit our new property
await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey(ConstantHelper.buttons.submit));

// ensure we no longer get an error that our property alias is invalid
await expect(page.locator('[alias="model.property.alias"] .umb-validation-label')).toBeHidden();

// Assert that the doc type has now been saved successfully
await umbracoUi.isSuccessNotificationVisible();

// Clean up
await umbracoApi.documentTypes.ensureNameNotExists(name);
await umbracoApi.templates.ensureNameNotExists(name);
Expand Down