Remove UmbracoPath setting
#16037
Merged
Remove UmbracoPath setting
#16037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuklon
reviewed
Apr 11, 2024
Co-authored-by: Nuklon <[email protected]>
ronaldbarendse
changed the title
UmbracoPath settingUmbracoPath setting
ronaldbarendse
force-pushed
the
v14/feature/remove-umbracopath
branch
from
e23244f to
f3104cd
Compare
# Conflicts: # Directory.Build.props # src/Umbraco.Cms.Api.Management/Controllers/BackOfficeLoginController.cs # src/Umbraco.Cms.Api.Management/Routing/BackOfficeAreaRoutes.cs # src/Umbraco.Cms.StaticAssets/umbraco/UmbracoLogin/Index.cshtml # src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/Maintenance.cshtml # src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NoNodes.cshtml # src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NotFound.cshtml # src/Umbraco.Core/Configuration/GlobalSettingsExtensions.cs # src/Umbraco.Core/Routing/UmbracoRequestPaths.cs # src/Umbraco.Web.Common/AspNetCore/AspNetCoreBackOfficeInfo.cs # src/Umbraco.Web.Common/Views/UmbracoViewPage.cs # src/Umbraco.Web.Website/Controllers/RenderNoContentController.cs # src/Umbraco.Web.Website/Extensions/HtmlHelperRenderExtensions.cs # tests/Umbraco.Tests.Integration/DependencyInjection/UmbracoBuilderExtensions.cs # tests/Umbraco.Tests.UnitTests/TestHelpers/Objects/TestUmbracoContextFactory.cs # tests/Umbraco.Tests.UnitTests/Umbraco.Core/Configuration/Models/GlobalSettingsTests.cs
AndyButland
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Am seeing if we can get this updated and in for 16 @ronaldbarendse. I've updated to the latest v15/dev and will now re-target for v16/dev. I just had one question on an update if you could help me out please.
AndyButland
approved these changes
Feb 21, 2025
Co-authored-by: Ronald Barendse <[email protected]>
# Conflicts: # src/Umbraco.Cms.Api.Management/Routing/BackOfficeAreaRoutes.cs
…mbraco/Umbraco-CMS into v14/feature/remove-umbracopath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building upon the changes in PR #16035 that obsoleted the full
UmbracoPathproperty, this actually removes it (as it's been obsoleted multiple major versions now).I've ensured all other changes are backwards-compatible, but if we decide that this isn't needed, we can remove quite a few constructors that will otherwise be used by DI and require resolving unused dependencies.I've merged and retargeted tov15/dev, so the obsoleted constructors are now removed.