-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Feature: Use uui invalid color #18273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts
I just had to test it does work here, maybe installing latest npm dependencies was missing when Welander tested. It does thought not inherit the yellow color scheme in the Block Workspace. But there validation issues are also preventing the user from submitting, so for now that is okay IMO. then we will correct that part of the experience later when we know if we like the user to be allowed to close modals with issues. |
src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts
Outdated
Show resolved
Hide resolved
@madsrasmussen I have corrected your suggestions. Though not the disabled save button, as it is not possible to save without a name. |
Fixes #17089
Fixes #18416
This PR. runs validation + server validation when saving Documents, without preventing save from happening.
Therefor this adjusts the validation feedback color for Saving vs. Publishing. So its not danger-red when Saving, just yellow.