Skip to content

Feature: Use uui invalid color #18273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 9, 2025
Merged

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Feb 10, 2025

Fixes #17089
Fixes #18416

This PR. runs validation + server validation when saving Documents, without preventing save from happening.
Therefor this adjusts the validation feedback color for Saving vs. Publishing. So its not danger-red when Saving, just yellow.

@nielslyngsoe nielslyngsoe marked this pull request as ready for review March 6, 2025 15:39
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) March 6, 2025 15:39
@Welander1994
Copy link
Contributor

The content node does get saved, but the feedback color is still danger-red and not yellow

Screenshot 2025-04-02 at 13 39 47

@nielslyngsoe nielslyngsoe changed the title Feature: Use uui invalid color (Awaiting new UUI version) Feature: Use uui invalid color Apr 3, 2025
@nielslyngsoe
Copy link
Member Author

I just had to test it does work here, maybe installing latest npm dependencies was missing when Welander tested.

image

It does thought not inherit the yellow color scheme in the Block Workspace. But there validation issues are also preventing the user from submitting, so for now that is okay IMO. then we will correct that part of the experience later when we know if we like the user to be allowed to close modals with issues.

@madsrasmussen
Copy link
Contributor

It is not related to this PR, but related to "the saving experience." 😄

I don't think it makes much sense to disable the save button until the user has entered something. We already allow saving an invalid document. Also, the "Save and Publish" button is enabled, which makes it even more confusing.

Screenshot 2025-04-07 at 09 29 29

@madsrasmussen
Copy link
Contributor

When saving a document, the saving process gets blocked by validation, which shouldn't be the case. I correctly see the "invalid" notifications. See the screenshot below. The save request doesn't get sent.

A small detail: I don't think the mandatory marker (*) should change color from red to yellow.

Screenshot 2025-04-07 at 09 38 03

@nielslyngsoe
Copy link
Member Author

@madsrasmussen I have corrected your suggestions. Though not the disabled save button, as it is not possible to save without a name.

@nielslyngsoe nielslyngsoe merged commit ba0028c into v15/dev Apr 9, 2025
22 of 23 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/feature/use-uui-invalid-color branch April 9, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants