[V13] User notifications not sent correctly when having more than 400 users

[vantovic]

Fixed #16575

[github-actions]

Hi there @vantovic, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[emmagarland]

Hi @vantovic,

Thanks for your PR to fix #16575, which was an issue you raised and described about user notifications not being sent correctly when having > 400 users.

I'm just following up on that ticket to confirm if HQ have been able to replicate it, before progressing this fix.

Also, it looks like this is your first PR to this repository! Nice work! #H5YR 🎉

Best wishes

Emma

[AndyButland]

This looks good to me @vantovic - thanks for the contribution.

I've just made a little update to optimize the retrieval of the users (getting just the approved ones back from the database, rather than getting all and then filtering). And resolved the merge conflicts.

I appreciate a little time has gone by but if you are able to have a quick look over my changes to make sure you are happy with them, please do. In any case though, I'll merge in later today or tomorrow.